Re: building pg_dump doesn't work - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: building pg_dump doesn't work
Date
Msg-id 20090303233315.GH4482@alvh.no-ip.org
Whole thread Raw
In response to Re: building pg_dump doesn't work  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: building pg_dump doesn't work  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tom Lane wrote:

> I think this is probably going in the wrong direction.  The reason
> gram.h isn't already in the main include tree is that we don't *want*
> all and sundry depending on it --- we have very carefully minimized
> the number of files that depend on the grammar's symbol codes.
> 
> ISTM that pg_dump doesn't actually care about the symbol codes, it
> just needs a list of known keywords.

Hmm, I had thought that pg_dump only wanted the header file, not the
keywords.o object file.  I now see that I was wrong.  I agree that your
proposed solution is a lot better.  I'll see about it.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: We will do releases soon because of bug #4680; please help test
Next
From: Fujii Masao
Date:
Subject: Re: Immediate shutdown and system(3)