Re: building pg_dump doesn't work - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: building pg_dump doesn't work
Date
Msg-id 20090303211827.GE4482@alvh.no-ip.org
Whole thread Raw
In response to building pg_dump doesn't work  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: building pg_dump doesn't work  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Alvaro Herrera wrote:
> Hi,
>
> I noticed that if you start from a clean tree, it doesn't work to build
> pg_dump because gram.h has not been generated yet:
>
> make -C ../../../src/backend/parser keywords.o
> make[1]: Entering directory `/home/alvherre/Code/CVS/pgsql/build/00head/src/backend/parser'
> gcc -O0 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
-fwrapv-g -I/pgsql/source/00head/src/backend/parser -I../../../src/include -I/pgsql/source/00head/src/include
-D_GNU_SOURCE-I/usr/include/libxml2   -c -o keywords.o /pgsql/source/00head/src/backend/parser/keywords.c -MMD -MP -MF
.deps/keywords.Po
> /pgsql/source/00head/src/backend/parser/keywords.c:33:25: error: parser/gram.h: No such file or directory
> /pgsql/source/00head/src/backend/parser/keywords.c:46: error: 'ABORT_P' undeclared here (not in a function)

This patch fixes it.

The fmgroids.h bits are not needed for pg_dump, but they are if you
start building on the parser directory.  I don't care strongly for that
one, so if people don't like it I'll just go ahead with the gram.h bit,
unless anyone has a better idea.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: building pg_dump doesn't work
Next
From: Tom Lane
Date:
Subject: Re: building pg_dump doesn't work