Tom Lane wrote:
> Simon Riggs <simon@2ndQuadrant.com> writes:
> > Can we add something to memory contexts to make this fail every time?
>
> No, not really. AFAICS the reason for Alvaro not seeing it must be that
> on his machine the new transaction happens to allocate its
> TopTransactionContext control block right in the same place where the
> old one was.
But freed memory is clobbered, so if we were to have an assert that
checks the node tag, it should show up. In fact, we do have such an
assert, but only for compilers other than GCC, because the inline
version of palloc() cannot have it for lack of infrastructure.
Maybe we should patch palloc.h so that it only uses the inline version
when not in assert mode. Something like the attached, except that for
some reason the test case still fails to report any error for me :-(
Maybe the cpp boolean logic is fooling me.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
