Re: async notification patch for dblink - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: async notification patch for dblink
Date
Msg-id 200901142212.n0EMC8W14754@momjian.us
Whole thread Raw
In response to async notification patch for dblink  ("Marcus Kempe" <marcus@kempe.cc>)
Responses Re: async notification patch for dblink  ("Marcus Kempe" <marcus.kempe@gmail.com>)
List pgsql-hackers
What is the status on this?

---------------------------------------------------------------------------

Marcus Kempe wrote:
> This patch adds the ability to retrieve async notifications using dblink,
> via the addition of the function dblink_get_notify.
> 
> It is written against cvs head, includes documentation and regression
> testing. It compiles, tests and works well.
> 
> I would be interested in some feedback on the regression test.
> My initial thought was to test the function as thoroughly as possible. So I
> perform listen and notify commands within the test to be able to test all
> aspects of the code. Even though this works well for me, I get the feeling
> that this is not the correct way to do it. I can find no other testing of
> the listen/notify functionality in the regression tests, and I imagine this
> is for good reason.
> If someone would care to explain this, and maybe give a hint about what
> amount of testing is appropriate for this fairly trivial patch, it would be
> appreciated.
> 
> Best regards,
> 
> Marcus Kempe

[ Attachment, skipping... ]

> 
> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: solaris libpq threaded build fails
Next
From: Tom Lane
Date:
Subject: Re: solaris libpq threaded build fails