Re: pg_restore --clean text - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_restore --clean text
Date
Msg-id 200901061718.n06HIrK29306@momjian.us
Whole thread Raw
In response to pg_restore --clean text  ("Erik Rijkers" <er@xs4all.nl>)
Responses Re: pg_restore --clean text  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Erik Rijkers wrote:
> The help text for the pg_restore --clean option in the documentation is IMHO more precise than the
> text that the pg_restore binary gives:
>
> documentation:
>  -c
>  --clean
>    Clean (drop) database objects before recreating them.
>
> pg_restore binary:
>    -c, --clean   clean (drop) schema prior to create
>
>
> So I think it would be an improvement to channge the pg_restore --help text:

I used the wording from the pg_restore SGML manual page in the --help
text, to be more consistent.  Thanks for the report.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/bin/pg_dump/pg_restore.c
===================================================================
RCS file: /cvsroot/pgsql/src/bin/pg_dump/pg_restore.c,v
retrieving revision 1.90
diff -c -c -r1.90 pg_restore.c
*** src/bin/pg_dump/pg_restore.c    5 Jan 2009 16:54:37 -0000    1.90
--- src/bin/pg_dump/pg_restore.c    6 Jan 2009 17:17:10 -0000
***************
*** 391,397 ****

      printf(_("\nOptions controlling the restore:\n"));
      printf(_("  -a, --data-only          restore only the data, no schema\n"));
!     printf(_("  -c, --clean              clean (drop) schema prior to create\n"));
      printf(_("  -C, --create             create the target database\n"));
      printf(_("  -I, --index=NAME         restore named index\n"));
      printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"
--- 391,397 ----

      printf(_("\nOptions controlling the restore:\n"));
      printf(_("  -a, --data-only          restore only the data, no schema\n"));
!     printf(_("  -c, --clean              clean (drop) database objects before recreating\n"));
      printf(_("  -C, --create             create the target database\n"));
      printf(_("  -I, --index=NAME         restore named index\n"));
      printf(_("  -L, --use-list=FILENAME  use specified table of contents for ordering\n"

pgsql-hackers by date:

Previous
From: "Kevin Grittner"
Date:
Subject: Re: Documenting serializable vs snapshot isolation levels
Next
From: Devrim GÜNDÜZ
Date:
Subject: Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1