Re: So, why shouldn't SET CONSTRAINTS set a transaction snapshot? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: So, why shouldn't SET CONSTRAINTS set a transaction snapshot?
Date
Msg-id 20081212225139.GN3806@alvh.no-ip.org
Whole thread Raw
In response to Re: So, why shouldn't SET CONSTRAINTS set a transaction snapshot?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: So, why shouldn't SET CONSTRAINTS set a transaction snapshot?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

> 1. Always set a snapshot for SET CONSTRAINTS.  This is a minus-one-liner
> --- just remove it from the exclusion list in PortalRunUtility.
> 
> 2. Have it set a snapshot only if it finds pending trigger events to
> fire.  This would only require another half dozen lines of code, but
> it's certainly more complicated than choice #1.

It seems to me there is room for a backwards compatibility argument
here.  How about doing #2 for 8.3 and back, and #1 for 8.4?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: So, why shouldn't SET CONSTRAINTS set a transaction snapshot?
Next
From: Markus Wanner
Date:
Subject: Re: Sync Rep: First Thoughts on Code