Re: auto_explain contrib moudle - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: auto_explain contrib moudle
Date
Msg-id 20081117192622.8029.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: auto_explain contrib moudle  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: auto_explain contrib moudle  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Re: auto_explain contrib moudle  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Ok, I'm looking at the direction of ExecutorStart/End hooks...

Tom Lane <tgl@sss.pgh.pa.us> wrote:

> This would likely require adding a struct Instrumentation * field to
> QueryDesc in which to track the total ExecutorRun timing

I think instr_time is enough here,
but why do you think Instrumentation is needed?

There might be another approach to have a stopwatch stack in
the contrib module instead of the core. I think it is cleaner
because it works even if multiple modules use the stopwatch
at the same time. Am I missing something?

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: "Hannes Eder"
Date:
Subject: Re: Stack trace
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: auto_explain contrib moudle