Re: optimizing CleanupTempFiles - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: optimizing CleanupTempFiles
Date
Msg-id 20080917234339.GJ3855@alvh.no-ip.org
Whole thread Raw
In response to Re: optimizing CleanupTempFiles  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: optimizing CleanupTempFiles  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: optimizing CleanupTempFiles  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Ah -- like this?
>
> +1, but there are two kinds of temp files in that module, and only
> one of them is relevant here.  Call it something like
> have_xact_temporary_files to make things clearer.

Ok, so that's what I called it.

Simon wrote:

> if test should include
>         || isProcExit
>
> so you don't skip non-transactional temp files at proc exit when there
> weren't any created in the last transaction.

Yep, I noticed that too.  Thanks.

Should I backpatch this to 8.3?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: optimizing CleanupTempFiles
Next
From: Alvaro Herrera
Date:
Subject: Re: optimizing CleanupTempFiles