Re: NDirectFileRead and Write - Mailing list pgsql-hackers

From ITAGAKI Takahiro
Subject Re: NDirectFileRead and Write
Date
Msg-id 20080908180748.983F.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: NDirectFileRead and Write  ("Hitoshi Harada" <umi.tanuki@gmail.com>)
List pgsql-hackers
"Hitoshi Harada" <umi.tanuki@gmail.com> wrote:

> so I guess all of these variables should be defined together but
> actually you put the two in buffile.h while the others in
> buf_internals.h. Is there clear reason for that?

That's because buffile.c includes buffile.h, but not buf_internals.h .
NDirectFileRead/Writes are counters for BufFile in the patch
and don't depend on bufmgr.

It might be cleaner if we had something like storage/bufstats.h
and declared all counter variables in it, but it seems to be an overkill.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center




pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Prototype: In-place upgrade v02
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: Synchronous Log Shipping Replication