Re: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.
Date
Msg-id 20080718033557.GT3934@alvh.no-ip.org
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > I think this patch has caused this new warning in psql:
> > 
> > /pgsql//source/00head/src/bin/psql/describe.c: In function ?describeOneTableDetails?:
> > /pgsql//source/00head/src/bin/psql/describe.c:832: warning: ?tableinfo.relkind? may be used uninitialized in this
function
> 
> I don't see that warning with my compiler so I have no way of testing
> this, but I do see this line pretty high in the function:
> 
>         tableinfo.relkind = *(PQgetvalue(res, 0, 1));

But it's before the first "goto error_return", after which it is checked.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Add column storage type to psql \d+ display.
Next
From: "Gurjeet Singh"
Date:
Subject: Load spikes on 8.1.11