Re: PATCH: CITEXT 2.0 v3 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: PATCH: CITEXT 2.0 v3
Date
Msg-id 20080709210103.GM3946@alvh.no-ip.org
Whole thread Raw
In response to Re: PATCH: CITEXT 2.0 v3  ("David E. Wheeler" <david@kineticode.com>)
List pgsql-hackers
David E. Wheeler wrote:
> On Jul 9, 2008, at 13:40, Alvaro Herrera wrote:

>> One thing that jumps at me is pgTAP usage, as Zdenek said.  I
>> understand that it's neat and all that, but we can't include the
>> tests because  they won't run unless one installs pgTAP which seems a
>> nonstarter.  So if  you want the tests in the repository along the
>> rest of the stuff, they really should use pg_regress.
>
> It does use pg_regress. The test just load the included pgtap.sql file
> to get the tap functions, and then away they go. If you run `make  
> installcheck` it works.

Uh-huh, OK, that's fine then I guess.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: PATCH: CITEXT 2.0 v3
Next
From: David Fetter
Date:
Subject: Re: [PATCHES] WITH RECURSIVE updated to CVS TIP