Re: WIP patch: reducing overhead for repeat de-TOASTing - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: WIP patch: reducing overhead for repeat de-TOASTing
Date
Msg-id 20080702150544.GS18252@alvh.no-ip.org
Whole thread Raw
In response to Re: WIP patch: reducing overhead for repeat de-TOASTing  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: WIP patch: reducing overhead for repeat de-TOASTing  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

> It would be simple enough to fix nodeSubplan.c to copy the data into
> an upper-level Slot rather than a bare tuple.  But this makes me wonder
> how many other places are like this.  In the past there wasn't that much
> benefit to pulling data from a Slot instead of a bare tuple, so I'm
> afraid we might have a number of similar gotchas we'd have to track
> down.

I compare this to adding CHECK_FOR_INTERRUPTS(): let's declare that
every usage of bare tuples is a not-very-serious bug, and we can fix
them one by one as we come across them.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Location for pgstat.stat
Next
From: Alvaro Herrera
Date:
Subject: Re: [WIP] patch - Collation at database level