rfc: add pg_dump options to dump output - Mailing list pgsql-hackers

From Robert Treat
Subject rfc: add pg_dump options to dump output
Date
Msg-id 200806021654.22126.xzilla@users.sourceforge.net
Whole thread Raw
Responses Re: rfc: add pg_dump options to dump output  (Josh Berkus <josh@agliodbs.com>)
Re: rfc: add pg_dump options to dump output  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I would like to add the flags given to pg_dump into the output of the pg_dump 
file. For text dumps, the output would go on a line below the current header, 
so output would look like:

--
-- PostgreSQL database dump complete
--
-- Generated by: pg_dump -s -U rob pagila 
--

For compressed dumps, the output could go into the headers created with -l, 
for example:

; Archive created at Mon Jun  2 16:43:19 2008
;     dbname: pgods
;     TOC Entries: 3
;     Compression: -1
;     Dump Version: 1.10-0
;     Format: CUSTOM
;     Integer: 4 bytes
;     Offset: 8 bytes
;     Dumped from database version: 8.3.1
;     Dumped by pg_dump version: 8.3.1
;     Generated by: pg_dump -s -U rob -Fc pagila
;
;
; Selected TOC Entries:


Anyone see any issues with this? Should there be other information taken into 
account? Does this need to be an option itself, or can we just do it in all 
cases? 

-- 
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL


pgsql-hackers by date:

Previous
From: Andreas 'ads' Scherbaum
Date:
Subject: Re: Core team statement on replication in PostgreSQL
Next
From: Josh Berkus
Date:
Subject: Re: rfc: add pg_dump options to dump output