Re: [COMMITTERS] pgsql: Don't call rm with empty file list. - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Don't call rm with empty file list.
Date
Msg-id 200805172127.m4HLRgA13546@momjian.us
Whole thread Raw
List pgsql-patches
Peter Eisentraut wrote:
> Log Message:
> -----------
> Don't call rm with empty file list.
>
> Modified Files:
> --------------
>     pgsql/src:
>         nls-global.mk (r1.12 -> r1.13)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/nls-global.mk?r1=1.12&r2=1.13)

FYI, I had to also apply the attached patch to fix it, but your example
on the line above was very helpful.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: src/nls-global.mk
===================================================================
RCS file: /cvsroot/pgsql/src/nls-global.mk,v
retrieving revision 1.13
diff -c -c -r1.13 nls-global.mk
*** src/nls-global.mk    17 May 2008 20:24:05 -0000    1.13
--- src/nls-global.mk    17 May 2008 20:59:27 -0000
***************
*** 78,84 ****

  clean-po:
      $(if $(MO_FILES),rm -f $(MO_FILES))
!     @rm -f $(addsuffix .old, $(PO_FILES))
      rm -f po/$(CATALOG_NAME).pot


--- 78,84 ----

  clean-po:
      $(if $(MO_FILES),rm -f $(MO_FILES))
!     @$(if $(PO_FILES),rm -f $(addsuffix .old, $(PO_FILES)))
      rm -f po/$(CATALOG_NAME).pot



pgsql-patches by date:

Previous
From: daveg
Date:
Subject: pg_dump lock timeout - resend
Next
From: Euler Taveira de Oliveira
Date:
Subject: Re: pg_dump lock timeout - resend