Re: What to do with inline warnings? - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: What to do with inline warnings?
Date
Msg-id 20080514173133.GB6456@svana.org
Whole thread Raw
In response to Re: What to do with inline warnings?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: What to do with inline warnings?  (Gregory Stark <stark@enterprisedb.com>)
Re: What to do with inline warnings?  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’:
> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
> > tqual.c:1057: error: called from here
> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
> > tqual.c:1061: error: called from here
>
> Hmm, it's a bit disturbing that the compiler is taking it upon itself to
> decide that these calls are "unlikely".

Perhaps would should give it some idea about how likely they'd be,
because clearly it has no idea now.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Please line up in a tree and maintain the heap invariant while
> boarding. Thank you for flying nlogn airlines.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib
Next
From: Andrew Dunstan
Date:
Subject: missing $PostgreSQL:$