Re: Improve shutdown during online backup, take 4 - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: Improve shutdown during online backup, take 4
Date
Msg-id 20080423154540.64dd7862@mha-laptop
Whole thread Raw
In response to Improve shutdown during online backup, take 2  ("Albe Laurenz" <laurenz.albe@wien.gv.at>)
Responses Re: Improve shutdown during online backup, take 4
List pgsql-patches
Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > +     if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> >
> > (there's a number of similar places)
>
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Applied with some minor changes to the error messages to make them
closer to our guidelines. (With my track record, it's not entirely
unlikely that someone will fix them further though :-P)

//Magnus

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Snapshot management, final
Next
From: Alvaro Herrera
Date:
Subject: Re: temporal version of generate_series()