Re: Lessons from commit fest - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Lessons from commit fest
Date
Msg-id 200804161639.m3GGdgc06624@momjian.us
Whole thread Raw
In response to Re: Lessons from commit fest  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander wrote:
> > And I think adopting surrounding naming, commeting, coding conventions
> > should come naturally as it can aide in copy-pasting too :)
> 
> I think pg_indent has to be made a lot more portable and easy to use
> before that can happen :-) I've run it once or twice on linux machines,
> and it comes out with huge changes compared to what Bruce gets on his
> machine. Other times, it doesn't :-) So yeah, it could be that it just
> needs to be made easier to use, because I may certainly have done
> something wrong.

Agreed, pgindent is too cumbersome to require patch submitters to use. 
One idea would be to allow C files to be emailed and the indented
version automatically returned via email.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Lessons from commit fest
Next
From: Tom Lane
Date:
Subject: Re: pg_terminate_backend() issues