Re: Lessons from commit fest - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Lessons from commit fest
Date
Msg-id 20080415161224.GG4429@alvh.no-ip.org
Whole thread Raw
In response to Re: Lessons from commit fest  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Lessons from commit fest  ("Joshua D. Drake" <jd@commandprompt.com>)
List pgsql-hackers
Tom Lane wrote:

> I tend to just fix this stuff while committing, rather than lecture the
> submitters about it, but it undoubtedly is a time sink.

Lesson learned: a useful task for another reviewer to do is to grab the
patch, fix the style issues, and post the fixed version.  That way, the
"higher level reviewer" does not have to waste time on a task that,
really, anybody can do.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Oleg Bartunov
Date:
Subject: Re: Problem with site doc search
Next
From: Gregory Stark
Date:
Subject: Re: [COMMITTERS] pgsql: Add pg_terminate_backend() to allow terminating only a single