Re: Headers dependencies cleanup - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Headers dependencies cleanup
Date
Msg-id 200804051431.m35EVxD18631@momjian.us
Whole thread Raw
In response to Re: Headers dependencies cleanup  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Headers dependencies cleanup
List pgsql-patches
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Zdenek Kotala wrote:
> >> During my work I found some header files, which include useless headers
> >> and on other way there are some headers which silently assume that
> >> requested header will be included by some other headers file.
> >>
> >> This patch fixes these dependencies around bufpage.h, bufmgr.h
>
> > What's the point here, again?
>
> Bruce periodically runs a script that's supposed to catch this type
> of problem.  Maybe we are overdue for another run?

Last run was July, 2006:

    revision 1.48
    date: 2006/07/13 18:01:01;  author: momjian;  state: Exp;  lines: +1 -2
    More include file adjustments.
    ----------------------------
    revision 1.47
    date: 2006/07/13 17:47:01;  author: momjian;  state: Exp;  lines: +2 -1
    More include file adjustments.
    ----------------------------
    revision 1.46
    date: 2006/07/13 16:49:19;  author: momjian;  state: Exp;  lines: +2 -1
    Allow include files to compile own their own.

    Strip unused include files out unused include files, and add needed
    includes to C files.

I run it every few years rather than every year because it can break
stuff that we have to manually fix by adding includes.

If you want it run now or every year, let me know.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: "Merlin Moncure"
Date:
Subject: Re: libpq type system 0.9a
Next
From: Bruce Momjian
Date:
Subject: Re: Headers dependencies cleanup