Re: Text <-> C string - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Text <-> C string
Date
Msg-id 20080325180819.GE12129@alvh.no-ip.org
Whole thread Raw
In response to Re: Text <-> C string  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane escribió:
> "Brendan Jurd" <direvus@gmail.com> writes:

> > A text_to_cstring_with_len() or text_to_cstring_limit() might be more
> > to the point, and more consistent with the other functions in the
> > family.
> 
> Hmm.  The thing that's bothering me is that the length is the size
> of the *destination*, which is not like cstring_to_text_with_len,
> so using a closely similar name might be confusing.  Of those two
> I'd go with text_to_cstring_limit.  Another thought that comes to
> mind is
> 
> void text_to_cstring_buffer(const text *src, char *dst, size_t dst_len)

text_to_cstring_buffer seems okay.  I did wonder for a bit whether it
should be 

void text_to_cstring_buffer(const text *src, char *buf, size_t buf_len)

but then the src/dst pair seems better than src/buf.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Text <-> C string
Next
From: Tom Lane
Date:
Subject: Re: gcc 4.3 breaks ContribCheck in 8.2 and older.