Re: Better error message for select_common_type() - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Better error message for select_common_type()
Date
Msg-id 200803241606.m2OG61w26816@momjian.us
Whole thread Raw
In response to Better error message for select_common_type()  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Added to TODO:

* Improve reporting of UNION type mismatches
 http://archives.postgresql.org/pgsql-hackers/2007-04/msg00944.php
http://archives.postgresql.org/pgsql-hackers/2008-03/msg00597.php


---------------------------------------------------------------------------

Peter Eisentraut wrote:
> So I was informed today that UNION types integer and text cannot be 
> matched.  Alright, but it failed to tell which particular expressions 
> in this 3-branch, 30-columns-each UNION clause in a 100-line statement 
> it was talking about.  So I made the attached patch to give some better 
> pointers.  Example:
> 
> peter=# values(0,1), (1::bigint,2), ('text'::text,3);
> ERROR:  42804: VALUES types bigint at position 2 and text at position 3 
> cannot be matched in instance 1
> 
> I'm not sure about the terminology "position" and "instance"; they're 
> just two coordinates to get at the problem.
> 
> None of this will help if you have multiple unrelated clauses that 
> invoke select_common_type(), but that might be better handled using the 
> parser location mechanism.
> 
> Comments?
> 
> -- 
> Peter Eisentraut
> http://developer.postgresql.org/~petere/

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
> 
>                 http://www.postgresql.org/about/donate

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://postgres.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Kurt Roeckx
Date:
Subject: Re: gcc 4.3 breaks ContribCheck in 8.2 and older.
Next
From: "Jeffrey Baker"
Date:
Subject: Re: Bug in libpq causes local clients to hang