Re: pgsql: Modify interactions between sinval.c and sinvaladt.c. - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Modify interactions between sinval.c and sinvaladt.c.
Date
Msg-id 20080317115104.GA6083@alvh.no-ip.org
Whole thread Raw
In response to Re: pgsql: Modify interactions between sinval.c and sinvaladt.c.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> alvherre@postgresql.org (Alvaro Herrera) writes:
> > Modify interactions between sinval.c and sinvaladt.c.  The code that actually
> > deals with the queue, including locking etc, is all in sinvaladt.c.  This means
> > that the struct definition of the queue, and the queue pointer, are now
> > internal "implementation details" inside sinvaladt.c.
>
> This looks good, but I wonder why you didn't move struct ProcState
> into sinvaladt.c as well?

I didn't notice that, thanks.  Done.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

pgsql-committers by date:

Previous
From: alvherre@postgresql.org (Alvaro Herrera)
Date:
Subject: pgsql: Move ProcState definition into sinvaladt.c from sinvaladt.h,
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Revert thinko introduced into prefix_selectivity() by my recent