Re: pgsql: Sync our regex code with upstream changes since last time we did - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Sync our regex code with upstream changes since last time we did
Date
Msg-id 20080215184555.GA22581@alvh.no-ip.org
Whole thread Raw
In response to Re: pgsql: Sync our regex code with upstream changes since last time we did  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Sync our regex code with upstream changes since last time we did
List pgsql-committers
Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>> Note that I didn't make any effort to duplicate a lot of cosmetic changes
>> that they made to bring their copy into line with their own style
>> guidelines, such as adding braces around single-line IF bodies.  Most of
>> those we either had done already (such as ANSI-fication of function headers)
>> or there is no point because pgindent would undo the change anyway.
>
> Not objecting, but IIRC we disabled the pgindent code that removes
> braces around single line (or rather statement) IF bodies several years
> ago.

Yeah, we did, because it was removing the braces around PG_TRY()
constructs.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Remove ancient restriction that LIMIT/OFFSET can't contain a
Next
From: meskes@postgresql.org (Michael Meskes)
Date:
Subject: pgsql: Updated expected result for regression test.