pgsql: Fix CREATE TABLE ... - Mailing list pgsql-committers

Log Message:
-----------
Fix CREATE TABLE ... LIKE ... INCLUDING INDEXES to not cause unwanted
tablespace permissions failures when copying an index that is in the
database's default tablespace.  A side-effect of the change is that explicitly
specifying the default tablespace no longer triggers a permissions check;
this is not how it was done in pre-8.3 releases but is argued to be more
consistent.  Per bug #3921 from Andrew Gilligan.  (Note: I argued in the
subsequent discussion that maybe LIKE shouldn't copy index tablespaces
at all, but since no one indicated agreement with that idea, I've refrained
from doing it.)

Modified Files:
--------------
    pgsql/src/backend/commands:
        indexcmds.c (r1.170 -> r1.171)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/indexcmds.c?r1=1.170&r2=1.171)
        tablecmds.c (r1.241 -> r1.242)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.241&r2=1.242)
    pgsql/src/backend/executor:
        execMain.c (r1.302 -> r1.303)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.302&r2=1.303)
    pgsql/src/backend/parser:
        parse_utilcmd.c (r2.8 -> r2.9)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.8&r2=2.9)
    pgsql/src/include/nodes:
        parsenodes.h (r1.358 -> r1.359)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.358&r2=1.359)