Re: message string fixes - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: message string fixes
Date
Msg-id 20080120223247.GB24325@alvh.no-ip.org
Whole thread Raw
In response to Re: message string fixes  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: message string fixes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Teodor Sigaev wrote:
>> aren't user-facing errors at all, and should be demoted to elog's,
>> correct?
>>
>>                 elog(ERROR, "invalid regis pattern: \"%s\"", str);
>
> Hmm. If regis detects an error in expression then it will be an error for 
> regex library too. At least, it was supposed to be.

And those that are not, probably are not what the user intends anyway,
with the pattern language being so narrow.

If all invalid regis patterns are indeed invalid regex patterns, then
just changing "regis" for "regex" should be enough.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: "Pavel Stehule"
Date:
Subject: Re: proposal: generic function, constructor function
Next
From: Mark Cave-Ayland
Date:
Subject: Re: Minor bug in src/port/rint.c