Re: logger subprocess including win32 - Mailing list pgsql-patches

From Tom Lane
Subject Re: logger subprocess including win32
Date
Msg-id 20080.1091732003@sss.pgh.pa.us
Whole thread Raw
In response to logger subprocess including win32  (Andreas Pflug <pgadmin@pse-consulting.de>)
Responses Re: logger subprocess including win32
List pgsql-patches
Andreas Pflug <pgadmin@pse-consulting.de> writes:
> Attached the patch, an orgy in #ifdefs, decorated with various indents
> and crlf line ends (glad we have pgindent).

I spent a fair amount of time fooling with this, trying to extract
something that I trusted enough to apply at this late date, but got
stuck on one point.  Exiting when the postmaster dies is *not* good
enough; we want the logger to stick around until the last process
upstream of the logger pipe is gone.  In the Unix case we can detect
this by watching for EOF on the pipe, but I don't know how to do the
equivalent in this threaded scheme you've devised for Windows.

(Why is the separate thread needed, again?)

            regards, tom lane

pgsql-patches by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: Win32 tablespace
Next
From: Andreas Pflug
Date:
Subject: Re: logger subprocess including win32