Re: Still a NOTICE in dict_thesaurus.c - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Still a NOTICE in dict_thesaurus.c
Date
Msg-id 200711272313.lARNDZt05046@momjian.us
Whole thread Raw
In response to Still a NOTICE in dict_thesaurus.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Still a NOTICE in dict_thesaurus.c
List pgsql-hackers
Thanks, working on this now.  Because the stop words can be any stop
word I didn't imagine it could be in the subsitution.  What stop word
will it use?  Anyway, coding it now to match the left-hand-side.

---------------------------------------------------------------------------

Tom Lane wrote:
> Wasn't this patch
> http://archives.postgresql.org/pgsql-committers/2007-11/msg00170.php
> supposed to fix things so that we wouldn't be throwing NOTICEs out of
> tsearch dictionary init functions?  It seems to have gotten only
> one of the two elog(NOTICE) calls in there.  The other one is for a
> stopword in the replacement phrase.  Is there any objection to making
> that an ERROR too?
> 
> Also, several of the elog's in this file ought to be ereport's since
> they are user-caused error conditions.  I think we are nominally past
> string freeze, but does anyone have an objection to changing them to
> ereport's?  If they don't get translated, the worst that will happen
> is that they come out in English, which is what's happening now.
> 
>             regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://postgres.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Re: Quality and Performance
Next
From: Tom Lane
Date:
Subject: Re: Still a NOTICE in dict_thesaurus.c