pgsql: Change fix_scan_expr() to avoid copying the input node tree in - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Change fix_scan_expr() to avoid copying the input node tree in
Date
Msg-id 20071124003944.E07B67540F0@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Change fix_scan_expr() to avoid copying the input node tree in the common case
where rtoffset == 0.  In that case there is no need to change Var nodes,
and since filling in unset opfuncid fields is always safe, scribbling on the
input tree to that extent is not objectionable.  This brings the cost of this
operation back down to what it was in 8.2 for simple queries.  Per
investigation of performance gripe from Guillaume Smet.

Modified Files:
--------------
    pgsql/src/backend/optimizer/plan:
        setrefs.c (r1.139 -> r1.140)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/setrefs.c?r1=1.139&r2=1.140)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Avoid uselessly building a duplicate of the original clause in
Next
From: momjian@postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Borland CC 5.5.1 needs ssize_t, per cnliou9@fastmail.fm.