Re: psql -f doesn't complain about directories - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: psql -f doesn't complain about directories
Date
Msg-id 20071114201941.GB13620@svana.org
Whole thread Raw
In response to Re: psql -f doesn't complain about directories  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: psql -f doesn't complain about directories  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Re: psql -f doesn't complain about directories  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Wed, Nov 14, 2007 at 05:15:20PM -0300, Alvaro Herrera wrote:
> > Should we do some kind of stat() before opening the file and abort if it's a
> > directory?
>
> Actually anything other than a plain file, right?  (Do we really want to
> be able to psql -f a_pipe?)

Sure, why not. To be honest I think that psql shouldn't be ignoring the
EISDIR error the kernel is returning.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Those who make peaceful revolution impossible will make violent revolution inevitable.
>  -- John F Kennedy

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: psql -f doesn't complain about directories
Next
From: Zdenek Kotala
Date:
Subject: Re: psql -f doesn't complain about directories