Re: [HACKERS] Unclarity of configure options - Mailing list pgsql-patches

Nikolay Samokhvalov wrote:
> The current (CVS version) configure script has the following options
> (among many others):
>
>   --enable-dtrace         build with DTrace support
>   --with-ossp-uuid        build with OSSP UUID library for UUID generation
>   --with-libxml           build with XML support
>   --with-libxslt          build with XSLT support
>
> One could think that adding any of this option to ./configure before
> building Postgres from sources, he will have corresponding support
> after installation and initdb process. But what we have now is the
> huge difference between "--with-libxml" and "--with-libxslt": while
> the first one adds XML support to the core, the second one doesn't
> provide anything automatically, it allows only using contirb/xml2
> (what is unclear because the help message is the same as for
> --with-libxml -- "build with ... support").

I have modified the configure message to be:

    --with-libxslt          build /contrib/xml2 with XSLT support

Patch attached.

> Also, comparing --enable-dtrace and --with-libxml I cannot see any
> difference in its semantics: --enable-dtrace also depends on external
> library and configure process fails if the system doesn't have it. So
> why "--enable-" is used in the first case and "--with-" in the second
> one?

I think the reason for this is because XML is seen as something added to
the backend (new capability) while dtrace is embedded in the backend.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: configure
===================================================================
RCS file: /cvsroot/pgsql/configure,v
retrieving revision 1.566
diff -c -c -r1.566 configure
*** configure    29 Oct 2007 11:25:42 -0000    1.566
--- configure    4 Nov 2007 17:52:55 -0000
***************
*** 898,904 ****
    --with-libedit-preferred  prefer BSD Libedit over GNU Readline
    --with-ossp-uuid        build with OSSP UUID library for UUID generation
    --with-libxml           build with XML support
!   --with-libxslt          build with XSLT support
    --with-system-tzdata=DIR  use system time zone data in DIR
    --without-zlib          do not use Zlib
    --with-gnu-ld           assume the C compiler uses GNU ld [default=no]
--- 898,904 ----
    --with-libedit-preferred  prefer BSD Libedit over GNU Readline
    --with-ossp-uuid        build with OSSP UUID library for UUID generation
    --with-libxml           build with XML support
!   --with-libxslt          build /contrib/xml2 with XSLT support
    --with-system-tzdata=DIR  use system time zone data in DIR
    --without-zlib          do not use Zlib
    --with-gnu-ld           assume the C compiler uses GNU ld [default=no]
Index: configure.in
===================================================================
RCS file: /cvsroot/pgsql/configure.in,v
retrieving revision 1.532
diff -c -c -r1.532 configure.in
*** configure.in    29 Oct 2007 11:25:42 -0000    1.532
--- configure.in    4 Nov 2007 17:52:55 -0000
***************
*** 600,607 ****
  #
  # XSLT
  #
! PGAC_ARG_BOOL(with, libxslt, no, [  --with-libxslt          build with XSLT support],
!               [AC_DEFINE([USE_LIBXSLT], 1, [Define to 1 to build with XSLT support. (--with-libxslt)])])


  AC_SUBST(with_libxslt)
--- 600,607 ----
  #
  # XSLT
  #
! PGAC_ARG_BOOL(with, libxslt, no, [  --with-libxslt          build /contrib/xml2 with XSLT support],
!               [AC_DEFINE([USE_LIBXSLT], 1, [Define to 1 to build /contrib/xml2 with XSLT support.
(--with-libxslt)])])


  AC_SUBST(with_libxslt)
Index: doc/src/sgml/installation.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/installation.sgml,v
retrieving revision 1.294
diff -c -c -r1.294 installation.sgml
*** doc/src/sgml/installation.sgml    6 Oct 2007 15:50:43 -0000    1.294
--- doc/src/sgml/installation.sgml    4 Nov 2007 17:52:56 -0000
***************
*** 973,981 ****
         <term><option>--with-libxslt</option></term>
         <listitem>
          <para>
!          Build with libxslt. The <filename>contrib/xml2</> module
!          relies on this library to perform Stylesheet transformations of
!          XML.
          </para>
         </listitem>
        </varlistentry>
--- 973,981 ----
         <term><option>--with-libxslt</option></term>
         <listitem>
          <para>
!          Build <filename>/contrib/xml2</> with libxslt.
!          <filename>/contrib/xml2</> relies on this library to perform
!          Stylesheet transformations of XML.
          </para>
         </listitem>
        </varlistentry>