Re: Latest ecpg patch broke MSVC build - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Latest ecpg patch broke MSVC build
Date
Msg-id 200710090119.l991JKn13989@momjian.us
Whole thread Raw
In response to Latest ecpg patch broke MSVC build  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
In hindsight, all these ecpg changes should have been made between beta1
and beta2 when we have time to deal with the fallout, not right before
beta1.

---------------------------------------------------------------------------

Tom Lane wrote:
> This morning's ecpg patch certainly seems to have been snake-bit.
> Although the Windows gcc buildfarm members seem happy, the MSVC ones
> are all failing with
> 
> Linking...
>            Creating library Release\libecpg\libecpg.lib and object Release\libecpg\libecpg.exp
>         libecpg.exp : error LNK2001: unresolved external symbol DllMain@12
>         .\Release\libecpg\libecpg.dll : fatal error LNK1120: 1 unresolved externals
> 
> I see that DllMain() got added to misc.c, so it's not obvious what's
> wrong here.  Some adjustment needed in the MSVC build scripts maybe?
> 
>             regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://postgres.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Next
From: Bruce Momjian
Date:
Subject: Re: Use of "postmaster"