pgsql: Keep the planner from failing on "WHERE false AND something IN - Mailing list pgsql-committers

Log Message:
-----------
Keep the planner from failing on "WHERE false AND something IN (SELECT ...)".
eval_const_expressions simplifies this to just "WHERE false", but we have
already done pull_up_IN_clauses so the IN join will be done, or at least
planned, anyway.  The trouble case comes when the sub-SELECT is itself a join
and we decide to implement the IN by unique-ifying the sub-SELECT outputs:
with no remaining reference to the output Vars in WHERE, we won't have
propagated the Vars up to the upper join point, leading to "variable not found
in subplan target lists" error.  Fix by adding an extra scan of in_info_list
and forcing all Vars mentioned therein to be propagated up to the IN join
point.  Per bug report from Miroslav Sulc.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/optimizer/plan:
        initsplan.c (r1.110.2.2 -> r1.110.2.3)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/initsplan.c?r1=1.110.2.2&r2=1.110.2.3)
        planmain.c (r1.89.2.1 -> r1.89.2.2)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planmain.c?r1=1.89.2.1&r2=1.89.2.2)
    pgsql/src/include/optimizer:
        planmain.h (r1.90 -> r1.90.2.1)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/planmain.h?r1=1.90&r2=1.90.2.1)