Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Date
Msg-id 20071003135820.GN22596@svr2.hagander.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Oct 02, 2007 at 10:04:19AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> >> I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99
percentof the messages coming out of that 
 
> >> routine, I bet. And things would still work correct in 0.9.8.
> 
> > Here's an example of what I meant.
> 
> +1, but I think you should "#ifndef HAVE_ERR_SET_MARK" the added code.
> Also, maybe try to fopen rather than just fstat?

Done on both, and applied.

//Magnus


pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: ECPG regression tests
Next
From: Alvaro Herrera
Date:
Subject: Re: First steps with 8.3 and autovacuum launcher