XLogCacheByte is unused - Mailing list pgsql-patches

From ITAGAKI Takahiro
Subject XLogCacheByte is unused
Date
Msg-id 20070827192456.74A2.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Whole thread Raw
Responses Re: XLogCacheByte is unused  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
I found XLogCtlData.XLogCacheByte is already unused in CVS HEAD.
Should we remove the variable, or reserve it for future use?

Index: src/backend/access/transam/xlog.c
===================================================================
--- src/backend/access/transam/xlog.c    (revision 1268)
+++ src/backend/access/transam/xlog.c    (working copy)
@@ -317,7 +317,6 @@
      */
     char       *pages;            /* buffers for unwritten XLOG pages */
     XLogRecPtr *xlblocks;        /* 1st byte ptr-s + XLOG_BLCKSZ */
-    Size        XLogCacheByte;    /* # bytes in xlog buffers */
     int            XLogCacheBlck;    /* highest allocated xlog buffer index */
     TimeLineID    ThisTimeLineID;

@@ -4115,8 +4114,6 @@
      * Do basic initialization of XLogCtl shared data. (StartupXLOG will fill
      * in additional info.)
      */
-    XLogCtl->XLogCacheByte = (Size) XLOG_BLCKSZ *XLOGbuffers;
-
     XLogCtl->XLogCacheBlck = XLOGbuffers - 1;
     XLogCtl->Insert.currpage = (XLogPageHeader) (XLogCtl->pages);
     SpinLockInit(&XLogCtl->info_lck);

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


pgsql-patches by date:

Previous
From: Stefan Kaltenbrunner
Date:
Subject: tab complete changes
Next
From: "Albe Laurenz"
Date:
Subject: documentation patch for LDAP service lookup