pgsql: Code review for regexp_matches/regexp_split patch. - Mailing list pgsql-committers

Log Message:
-----------
Code review for regexp_matches/regexp_split patch.  Refactor to avoid assuming
that cached compiled patterns will still be there when the function is next
called.  Clean up looping logic, thereby fixing bug identified by Pavel
Stehule.  Share setup code between the two functions, add some comments, and
avoid risky mixing of int and size_t variables.  Clean up the documentation a
tad, and accept all the flag characters mentioned in table 9-19 rather than
just a subset.

Modified Files:
--------------
    pgsql/doc/src/sgml:
        func.sgml (r1.383 -> r1.384)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml?r1=1.383&r2=1.384)
    pgsql/src/backend/utils/adt:
        regexp.c (r1.71 -> r1.72)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/regexp.c?r1=1.71&r2=1.72)
    pgsql/src/test/regress/expected:
        strings.out (r1.32 -> r1.33)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/strings.out?r1=1.32&r2=1.33)
    pgsql/src/test/regress/sql:
        strings.sql (r1.21 -> r1.22)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/strings.sql?r1=1.21&r2=1.22)