BUG #3439: pg_standby and path name with space - Mailing list pgsql-bugs

From ISHIDA Akio
Subject BUG #3439: pg_standby and path name with space
Date
Msg-id 200707121936.l6CJaspu085640@wwwmaster.postgresql.org
Whole thread Raw
Responses Re: BUG #3439: pg_standby and path name with space  ("Simon Riggs" <simon@2ndquadrant.com>)
List pgsql-bugs
The following bug has been logged online:

Bug reference:      3439
Logged by:          ISHIDA Akio
Email address:      iakio@mono-space.net
PostgreSQL version: CVS HEAD
Operating system:   Windows XP
Description:        pg_standby and path name with space
Details:

pg_standby failed if path name containing spaces.

C:\Documents and Settings\ishida\pgsql>pg_standby -d "C:\Documents and
Settings\ ishida\pgsql\archive_dir" 000000010000000000000000 data\pg_xlog

Trigger file            : <not set>
Waiting for WAL file    : C:\Documents and
Settings\ishida\pgsql\archive_dir\000000010000000000000000
WAL file path           : 000000010000000000000000
Restoring to...         : data\pg_xlog
Sleep interval          : 5 seconds
Max wait interval       : 0 forever
Command for restore     : copy C:\Documents and
Settings\ishida\pgsql\archive_dir\000000010000000000000000 data\pg_xlog
Num archived files kept : all files
running restore         :The system cannot find the file specified.
The system cannot find the file specified.
The system cannot find the file specified.
not restored            :


--- pg_standby.c        26 Jun 2007 22:05:02 -0000      1.6
+++ pg_standby.c        12 Jul 2007 19:03:19 -0000
@@ -69,7 +69,7 @@
 int nextWALFileType;

 #define SET_RESTORE_COMMAND(cmd, arg1, arg2) \
-       snprintf(restoreCommand, MAXPGPATH, cmd " %s %s", arg1, arg2)
+       snprintf(restoreCommand, MAXPGPATH, cmd " \"%s\" \"%s\"", arg1,
arg2)

 struct stat stat_buf;

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #3438: Problem selecting backslash from a byte array
Next
From: "Simon Riggs"
Date:
Subject: Re: BUG #3439: pg_standby and path name with space