Re: ecpg regression broken on mingw - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: ecpg regression broken on mingw
Date
Msg-id 20070614123529.GB29032@svr2.hagander.net
Whole thread Raw
In response to Re: ecpg regression broken on mingw  (Joachim Wieland <joe@mcknight.de>)
Responses Re: ecpg regression broken on mingw
List pgsql-hackers
On Thu, Jun 14, 2007 at 02:28:26PM +0200, Joachim Wieland wrote:
> 
> 
> On Thu, Jun 14, 2007 at 08:17:05AM -0400, Andrew Dunstan wrote:
> > Maybe it uses a different CVS or something. Who knows? Aren't our diffs 
> > supposed to be done ignoring whitespace?
> 
> pg_init() in pg_regress_ecpg.c has:
> 
>         /* no reason to set -w for ecpg checks, except for when on windows */
>         if (strstr(host_platform, "-win32"))
>                 basic_diff_opts = "-w";
>         else
>                 basic_diff_opts = "";
> 
> What value does host_platform have on MinGW?

That could certainly be it - on the failing machine, it's:
i686-pc-mingw32

Dave, any chance you can change that check to look for both -win32 and
-mingw32 and give it a test run on vaquita?

(I'll see if I have a vmware around that can run the build meanwhile, but
if it's easy for you to do..)

//Magnus



pgsql-hackers by date:

Previous
From: Joachim Wieland
Date:
Subject: Re: ecpg regression broken on mingw
Next
From: Magnus Hagander
Date:
Subject: Re: ecpg regression broken on mingw