Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Nikolay Samokhvalov wrote:
> Here is new version that adds following changes:
> 4. Function is now strict, per discussion.
> 5. Return empty array in case when XPath expression detects nothing
> (previously, NULL was returned in such case), per discussion.
> 6. (bugfix) Work with fragments with prologue: select xpath('/a',
> '<?xml version="1.0"?><a /><b />'); // now XML datum is always wrapped
> with dummy <x>...</x>, XML prologue simply goes away (if any).
> 7. Some cleanup.
>
> On 4/4/07, Nikolay Samokhvalov <nikolay@samokhvalov.com> wrote:
> > The patch attached contains following changes:
> > 1. The function name xmlpath() is changed to xpath();
> > 2. Approach of passing of namepspace mappings to the function is changed:
> > now that array (the 3rd argument) should be a 2-dimentional array with the
> > length of the second axis = 2 (e.g., ARRAY[ARRAY['a1', 'http://a1'],
> > ARRAY['a2', 'http://a2'], ARRAY['a2', 'http://a2']]);
> > 3. Description of xpath() function in docs (I'm sorry for possible
> > mistakes in English and docbook formatting, please check it...)
> >
> >
> > On 4/3/07, Bruce Momjian <bruce@momjian.us> wrote:
> > > Nikolay Samokhvalov wrote:
> > > > On 3/22/07, Peter Eisentraut < peter_e@gmx.net> wrote:
> > > > > Bruce Momjian wrote:
> > > > > > Patch applied.
> > > > >
> > > > > This code seems to think that if an xml datum starts with "<?xml" it's
> > a
> > > > > document. That is completely bogus.
> > > >
> > > > Agreed. I'll fix it.
> > >
> > > Nikolay, it has been a week, and I have see no fixes from you in
> > > response to requests from Peter. If the patch doesn't arrive in 1-2
> > > days, I will have to revert your patch and it will be kept for 8.4.
> > > Feature freeze was April 1, 2007.
> > >
> > > --
> > > Bruce Momjian <bruce@momjian.us> http://momjian.us
> > > EnterpriseDB
> > http://www.enterprisedb.com
> > >
> > > + If your life is a hard drive, Christ can be your backup. +
> > >
> >
> >
> >
> > --
> > Best regards,
> > Nikolay
> >
>
>
> --
> Best regards,
> Nikolay
[ Attachment, skipping... ]
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
