Re: [HACKERS] [Fwd: Index Advisor] - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] [Fwd: Index Advisor]
Date
Msg-id 200704112052.l3BKqGI17906@momjian.us
Whole thread Raw
In response to Re: [HACKERS] [Fwd: Index Advisor]  ("Gurjeet Singh" <singh.gurjeet@gmail.com>)
Responses Re: [HACKERS] [Fwd: Index Advisor]  ("Gurjeet Singh" <singh.gurjeet@gmail.com>)
List pgsql-patches
Gurjeet Singh wrote:
>     The interface etc. may not be beautiful, but it isn't ugly either! It is
> a lot better than manually creating pg_index records and inserting them into
> cache; we use index_create() API to create the index (build is deferred),
> and then 'rollback to savepoint' to undo those changes when the advisor is
> done. index_create() causes pg_depends entries too, so a 'RB to SP' is far
> much safer than going and deleting cache records manually.

My complaint was not that the API used in the code was non-optimal(which
I think was Tom's issue), but that the _user_ API was not very clean.
Not sure what to recommend, but I will think about it later.

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: "Merlin Moncure"
Date:
Subject: patch to suppress psql timing output in quiet mode
Next
From: Bruce Momjian
Date:
Subject: Re: Packed Varlena Update (v21)