Re: non-recursive WITH clause support - Mailing list pgsql-patches

From David Fetter
Subject Re: non-recursive WITH clause support
Date
Msg-id 20070410001846.GH27243@fetter.org
Whole thread Raw
In response to Re: non-recursive WITH clause support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: non-recursive WITH clause support
Re: non-recursive WITH clause support
List pgsql-patches
On Mon, Apr 09, 2007 at 06:43:08PM -0400, Tom Lane wrote:
> Gregory Stark <stark@enterprisedb.com> writes:
> > Here's an updated patch that fixes the bug I had. This is now functional basic
> > non-recursive WITH clause support.
> >  http://community.enterprisedb.com/recursive/with-pg82stable-v2.patch.gz
> > It's a pretty short simple patch as is; it just directly inlines any WITH
> > clauses as if they had been written as subqueries.
>
> So this does not really add any new functionality, it's just variant
> syntax for something you can do about as easily without it, right?

Not totally as easily.  For example, you can do some kinds of
aggregation with a few fewer keystrokes.

> The downside that I see is is that it changes WITH and SET into fully
> reserved words, which no doubt will break a few people's applications.

Really?

> While we're probably going to have to do that eventually, I'd like
> to be able to point to some non-negligible benefit resulting from
> the change when we do it.
>
> So my inclination is to not apply this in its current form, but to
> wait for the full recursive-WITH feature before taking the
> compatibility hit.

Is there some way to poll people for uses of WITH and SET in places
they shouldn't be?

Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666
                              Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: non-recursive WITH clause support
Next
From: Bruce Momjian
Date:
Subject: Re: RESET SESSION v3