Re: guc patch: Make variables fall back to default values - Mailing list pgsql-patches

From Joachim Wieland
Subject Re: guc patch: Make variables fall back to default values
Date
Msg-id 20070313105418.GA18913@mcknight.de
Whole thread Raw
In response to Re: guc patch: Make variables fall back to default values  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: guc patch: Make variables fall back to default values
List pgsql-patches
On Tue, Mar 13, 2007 at 08:22:17AM +0000, Gregory Stark wrote:
> The code seems to assume that all custom variables are strings. There are
> about half a dozen Assert(variable->vartype == PGC_STRING) throughout the
> patch. That's not true, plperl's use_strict is a boolean and we have
> DefineCustome*Variable functions for each type of variable. Perl bombs
> because plperl.use_strict is a boolean.

The attached patch removes those Asserts.

But this is not the whole story. I wonder why setting "plperl.use_strict"
is supposed to work at all? Where is the corresponding definition of
"plperl" as a custom variable class? I can add it manually to
postgresql.conf and make the regression tests work but is this the intended
way?


Joachim


Attachment

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pgbench on mingw needs fflush
Next
From: Heikki Linnakangas
Date:
Subject: Re: Recalculating OldestXmin in a long-running vacuum