Re: Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation
Date
Msg-id 20070309031738.GA19555@alvh.no-ip.org
Whole thread Raw
In response to Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation  (Tatsuhito Kasahara <kasahara.tatsuhito@oss.ntt.co.jp>)
Responses Re: Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation
Re: Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation
List pgsql-patches
Tatsuhito Kasahara wrote:
> Hello.
>
> I found a bug in contrib/pgstatindex.c to reports a strange value of
> leaf_fragmentation with some cases.
> #Look the following test example.
>
> In GetBTPageStatistics(),  stat->fragments is not initialized properly
> so that invalid leaf_fragments values are inserted in results.

Right.  Checking that code, it seems btpo.xact is also being incorrectly
handled, is it not?  Incidentally, the return value seems a bit useless.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment

pgsql-patches by date:

Previous
From: "Nikolay Samokhvalov"
Date:
Subject: Re: xpath_array with namespaces support
Next
From: Alvaro Herrera
Date:
Subject: Re: Patch for pgstatindex to fix a bug reporting a value of strange leaf_fragmentation