Re: msvc failure in largeobject regression test - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: msvc failure in largeobject regression test
Date
Msg-id 200702202211.l1KMBfK12288@momjian.us
Whole thread Raw
In response to Re: msvc failure in largeobject regression test  (Magnus Hagander <magnus@hagander.net>)
Responses Re: msvc failure in largeobject regression test  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Was this problem addressed?

---------------------------------------------------------------------------

Magnus Hagander wrote:
> On Tue, Jan 23, 2007 at 11:39:23AM -0800, Jeremy Drake wrote:
> > On Tue, 23 Jan 2007, Magnus Hagander wrote:
> > 
> > > On Tue, Jan 23, 2007 at 09:31:40AM -0500, Andrew Dunstan wrote:
> > > > Magnus Hagander wrote:
> > > > >Hi!
> > > > >
> > > > >I get failures for the largeobject regression tests on my vc++ build. I
> > > > >don't think this has ever worked, given that those tests are fairly new.
> > > > >Any quick ideas on what's wrong before I dig deeper?
> > > > >
> > > > >
> > > > [snip]
> > > >
> > > > I wonder if this is a line-end issue? Assuming you are working from CVS,
> > > > does your client turn \n into \r\n ? I see that other windows boxes are
> > > > happily passing this test on the buildfarm, and of course the mingw cvs
> > > > doesn't adjust line endings.
> > >
> > > Bingo!
> > >
> > > That's it. I copeid the file in binary mode from a linux box and now it
> > > passes.
> > 
> > I thought about that when I wrote it, and thus tried it under mingw and
> > cygwin without issue ;)  I don't think the regression tests were in a
> > position of running on the msvc build at the time...  My thought for what
> > to do if this did run into a problem would be an alternate output file
> > that is also acceptable (I don't know what they're called but other tests
> > have them IIRC).
> 
> Either that, or we require a checkout using Unix style linefeeds. I've
> confirmed that removing the file and checking it back out with "cvs --lf
> update tenk.data" works - tests pass fine.
> 
> Yet another option might be to flag that file as binary in cvs, in which
> case I think cvsnt shouldn't go mess with it.
> 
> //Magnus
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo@postgresql.org so that your
>        message can get through to the mailing list cleanly

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [pgsql-patches] pg_get_domaindef
Next
From: Oleg Bartunov
Date:
Subject: Re: tsearch in core patch, for inclusion