Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on" - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Date
Msg-id 200702140445.l1E4jLQ17242@momjian.us
Whole thread Raw
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> Bruce Momjian <bruce@momjian.us> writes:
> >>> !         if (SOCK_ERRNO != ECONNRESET)
> >>> !             SSL_shutdown(conn->ssl);
> >> 
> >> Ummm ... what is this supposed to fix exactly, and what are the odds
> 
> > I think the user was getting SIGPIPE on SSL_shutdown() of a closed
> > connection.
> 
> It seems moderately improbable that by the time control arrives here,
> errno still has anything to do with the last operation on the SSL
> socket.

Yep, I was wondering that too.  It is called SOCK_ERRNO, but in fact it
is just errno on Unix.

I generated the patch just to try to give an example of what the user
might be suggesting.  Let's see if anyone wants to research this more.

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Day and month name localization uses wrong locale category
Next
From: "Jeroen T. Vermeulen"
Date:
Subject: Cosmetic note: hit rates in logs