Re: [PATCHES] SGML index build fix - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] SGML index build fix
Date
Msg-id 200701100158.l0A1wAF08050@momjian.us
Whole thread Raw
In response to Re: [PATCHES] SGML index build fix  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > > ! draft:
> > > ! ifndef DRAFT
> > > ! ifneq ($(MAKECMDGOALS), draft)
>
> How could this condition ever match?

On first call, 'draft' might be set, but in the recursive call, this
code will not be reached because DRAFT iss set.

---------------------------------------------------------------------------

>
> > > ! # Call ourselves with the DRAFT value set. ?This seems to be the only
> > > ! # way to set gmake variables in a rule.
> > > ! ????@$(MAKE) DRAFT="Y" $(MAKECMDGOALS))
> > > ? else
> > > ! # run default 'all' rule
> > > ! ????@$(MAKE) DRAFT="Y" html
> > > ! endif
> > > ? endif
>
> --
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faq

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] SGML index build fix
Next
From: ITAGAKI Takahiro
Date:
Subject: Re: Load distributed checkpoint