Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow(). - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().
Date
Msg-id 200701060254.l062sjE05206@momjian.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Put back ERANGE test in dpow().  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Log Message:
> -----------
> Put back ERANGE test in dpow().  There are platforms that need this,
> like my HPPA ...

It ERANGE's only on Inf, not underflow?  I would prefer:

    else if (errno == ERANGE && !isinf(result))

because the sign computation isn't 100%, think pow(-1e300, 2) == Inf,
not -Inf.  But of course, that is going throw an error anyway, so either
we care about the sign of the Inf and try to get it right using isinf(),
or we just ignore it and use +Inf always.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Jim Nasby
Date:
Subject: Re: [HACKERS] Patch to log usage of temporary files
Next
From: Tom Lane
Date:
Subject: Re: A patch to pg_regress for Windows port