Re: SSI implementation question - Mailing list pgsql-hackers

From Tom Lane
Subject Re: SSI implementation question
Date
Msg-id 20067.1319061153@sss.pgh.pa.us
Whole thread Raw
In response to Re: SSI implementation question  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: SSI implementation question
List pgsql-hackers
"Kevin Grittner" <Kevin.Grittner@wicourts.gov> writes:
> Dan Ports <drkp@csail.mit.edu> wrote:
>> the sxact's lastCommitBeforeSnapshot needs to match the snapshot,
>> SxactGlobalXmin needs to be set to the correct value, etc. That's
>> why the call to GetSnapshotData happens from where it does
> Oh, right.  I knew I was forgetting something.  What if that was
> captured as part of building a snapshot?  That seems like it would
> be a trivial cost compared to other snapshot-building activity, and
> might give us a way to get this out from under the
> SerializableXactHashLock locking.

But aren't the values you need to fetch protected by
SerializableXactHashLock?  Having to take an additional LWLock is
*not* a "trivial cost".
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [v9.2] Fix Leaky View Problem
Next
From: "Kevin Grittner"
Date:
Subject: Re: SSI implementation question