Tom Lane wrote:
> Quite a few buildfarm members are failing with variants of "Undefined
> symbol: _canonicalize_path" in libpq. I think your recent patch that
> calls canonicalize_path from fe-connect.c is misguided in the first
> place; you certainly didn't ask for any discussion before applying it.
I sure did:
http://archives.postgresql.org/pgsql-patches/2006-05/msg00198.php
I didn't realize path.c wasn't already being used by libpq. I have
removed the canonicalize_path() call and added a comment; patch
attached.
--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Index: src/interfaces/libpq/fe-connect.c
===================================================================
RCS file: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v
retrieving revision 1.329
diff -c -c -r1.329 fe-connect.c
*** src/interfaces/libpq/fe-connect.c 17 May 2006 21:50:54 -0000 1.329
--- src/interfaces/libpq/fe-connect.c 18 May 2006 16:21:36 -0000
***************
*** 3110,3128 ****
if (hostname == NULL)
hostname = DefaultHost;
else if (is_absolute_path(hostname))
! {
! char canon_host[MAXPGPATH];
! char canon_def_socket[MAXPGPATH];
!
! StrNCpy(canon_host, hostname, MAXPGPATH);
! StrNCpy(canon_def_socket, DEFAULT_PGSOCKET_DIR, MAXPGPATH);
!
! canonicalize_path(canon_host);
! canonicalize_path(canon_def_socket);
!
! if (strcmp(canon_host, canon_def_socket) == 0)
hostname = DefaultHost;
- }
if (port == NULL)
port = DEF_PGPORT_STR;
--- 3110,3122 ----
if (hostname == NULL)
hostname = DefaultHost;
else if (is_absolute_path(hostname))
! /*
! * We should probably use canonicalize_path(), but then
! * we have to bring path.c into libpq, and it doesn't
! * seem worth it.
! */
! if (strcmp(hostname, DEFAULT_PGSOCKET_DIR) == 0)
hostname = DefaultHost;
if (port == NULL)
port = DEF_PGPORT_STR;
