Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling - Mailing list pgsql-patches

From Jim C. Nasby
Subject Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling
Date
Msg-id 20060511233703.GB4268@pervasive.com
Whole thread Raw
In response to [PATCH] Improve EXPLAIN ANALYZE overhead by sampling  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: [PATCH] Improve EXPLAIN ANALYZE overhead by sampling  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-patches
On Tue, May 09, 2006 at 10:37:04PM +0200, Martijn van Oosterhout wrote:
> Note that the resulting times still include the overhead actually
> incurred, I didn't filter it out. I want the times to remain reflecting
> reality as closely as possible.

If we actually know the overhead I think it'd be very useful at times to
be able to remove it, especially if you're actually trying to compare to
the planner estimates. Maybe worth adding an option to the command?

> - I also didn't make it optional. I'm unsure about whether it should be
> optional or not, given the number of cases where it will make a
> difference to be very few.

The real question is how important it is to have the real data in the
cases where it would make a difference, and I suspect we can't answer
that until this is out in the field. It *might* be worth a #define or
some other way to disable it that doesn't require patching code, but
probably not.
--
Jim C. Nasby, Sr. Engineering Consultant      jnasby@pervasive.com
Pervasive Software      http://pervasive.com    work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf       cell: 512-569-9461

pgsql-patches by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: Have configure complain about unknown options
Next
From: Matteo Beccati
Date:
Subject: Re: [HACKERS] Enhanced containment selectivity function