Re: [TODO] Allow commenting of variables ... - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [TODO] Allow commenting of variables ...
Date
Msg-id 20060510201744.GA26403@surnet.cl
Whole thread Raw
In response to [TODO] Allow commenting of variables ...  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: Bug in signal handler [Was: [TODO] Allow commenting
List pgsql-hackers
Zdenek Kotala wrote:

> I performed some investigation and I found that signal handler
> (SIGHUP_handler) contents a big code and contents signal nonsafe
> functions. It should generate deadlock or damage some internal data
> structure in the standard c library. See
> http://www.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_04.html
> for detail. By my opinion is necessary to rewrite signal handling in
> postmaster to avoid postgres malfunction.  

Perhaps you missed these lines:
       /*        * Block all signals until we wait again.  (This makes it safe for our        * signal handlers to do
nontrivialwork.)        */       PG_SETMASK(&BlockSig);
 

postmaster.c 1227ff

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: sblock state on FreeBSD 6.1
Next
From: Mark Dilger
Date:
Subject: Re: BEGIN inside transaction should be an error